Hi Marek,
On 6/24/26 4:28 PM, Marek Vasut wrote:
On 6/24/26 4:15 PM, Quentin Schulz wrote:
Hi Alexey, Tom,
On 5/12/26 3:55 PM, Alexey Charkov wrote:
Corechips SL6341 is a 4-port USB 2.0 and 3.0 hub controller. It always
requires external 1V1 power and can optionally use external 3V3 power
(or alternatively it has a 5V->3V3 LDO built in to derive 3V3 power from
VBUS). It also exposes a reset pin.
Device tree bindings are merged for upstream release with Linux 7.1 as
commit bfcb86e58f3a ("dt-bindings: usb: Add Corechips SL6341 USB2.0/3.0
hub controller") [1]
Link: https://eur02.safelinks.protection.outlook.com/?
url=https%3A%2F%2Fgithub.com%2Ftorvalds%2Flinux%2Fcommit%2F&data=05%7C02%7Cquentin.schulz%40cherry.de%7Ca44d3da6a7cf48b547ca08ded1fcee13%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639179081433018185%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=FecJhM5NGeAK%2Bo6iln1t3m52BN1DPNVV6tuQA4K4KWc%3D&reserved=0 bfcb86e58f3a58d05b95970d81b94cb011982780 [1]
Signed-off-by: Alexey Charkov <[email protected]>
---
Changes in v2:
- Fixed the comment to correctly indicate the USB 3.0 entry
- Added an upstream commit reference for the DT binding
- V for volts in captials (commit message, thanks Marek)
- Reordered the compatibles by lexical order, not hex order (thanks
Marek)
- Link to v1: https://eur02.safelinks.protection.outlook.com/?
url=https%3A%2F%2Flore.kernel.org%2Fr%2F20260512-sl6341-
&data=05%7C02%7Cquentin.schulz%40cherry.de%7Ca44d3da6a7cf48b547ca08ded1fcee13%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639179081433057206%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=Te0MkaUEYkT9gxZvlDl8HlVJKQMpKAS2PHjMjtNK5Q8%3D&reserved=0 [email protected]
---
common/usb_onboard_hub.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/common/usb_onboard_hub.c b/common/usb_onboard_hub.c
index 6fc34489a98f..0684f7bfd479 100644
--- a/common/usb_onboard_hub.c
+++ b/common/usb_onboard_hub.c
@@ -262,6 +262,12 @@ static int usb_onboard_hub_remove(struct udevice
*dev)
return ret;
}
+static const struct onboard_hub_data corechips_sl6341_data = {
+ .reset_us = 10000,
+ .num_supplies = 2,
+ .supply_names = { "vdd1v1-supply", "vdd3v3-supply" },
+};
+
static const struct onboard_hub_data usb2514_data = {
.power_on_delay_us = 500,
.reset_us = 1,
@@ -285,7 +291,13 @@ static const struct onboard_hub_data usbhx3_data
= {
static const struct udevice_id usb_onboard_hub_ids[] = {
/* Use generic usbVID,PID dt-bindings (usb-device.yaml) */
- { .compatible = "usb424,2514", /* USB2514B USB 2.0 */
+ { .compatible = "usb3431,6241", /* Corechips SL6341 USB
2.0 */
Would be nice to have an additional newline after the opening curly
bracket to avoid this unnecessary chunk in the diff next time we add
support for yet another USB hub. It's also a bit surprising to add it
first in the list instead of last, but eh, nothing too important.
Reviewed-by: Quentin Schulz <[email protected]>
@Tom, can you take this for next please?
Why would Tom collect USB patches ?
$ ./scripts/get_maintainer.pl -f common/usb_onboard_hub.c
Tom Rini <[email protected]> (maintainer:THE REST)
and this patch has been sitting reviewed for 6 weeks and the status in
patchwork is still "new" so I thought it somehow got lost. I did miss
that you were the delegate (or did this change recently?). My intention
was not to bypass you, my apologies if it was taken this way.
Would you mind if I send a patch to MAINTAINERS to add
common/usb_onboard_hub.c to the USB entry so that it's clear you're the
maintainer?
Cheers,
Quentin
