Hi Heinrich, On Wed, 1 Jul 2026 at 14:29, Heinrich Schuchardt <[email protected]> wrote: > > On 7/1/26 13:59, Simon Glass wrote: > > Hi Heinrich, > > > > On 2026-06-28T08:27:58, Heinrich Schuchardt > > <[email protected]> wrote: > >> efi_loader: use pointers in efi_acpi_register() > >> > >> Both efi_add_memory_map() and efi_install_configuration_table() expect > >> pointers and not virtual sandbox addresses. > >> > >> We need to convert the virtual sandbox addresses in efi_acpi_register() to > >> pointers in memory before using them. > >> > >> Signed-off-by: Heinrich Schuchardt <[email protected]> > >> > >> lib/efi_loader/efi_acpi.c | 35 +++++++++++++++++++++-------------- > >> 1 file changed, 21 insertions(+), 14 deletions(-) > > > > I think you missed a few things from the v2 review. > > > > Regards, > > Simon > > Which ones?
The EFI_PAGE_MASK -> EFI_PAGE_SIZE change should really have a mention in the commit message, if it isn't its own patch. The main one was my comment about the confusing pointer code - see my suggestion for how to avoid casts, etc. Regards, Simon
