On 7/2/26 1:13 PM, Simon Glass wrote: [...]
diff --git a/tools/binman/etype/nxp_imx8mimage.py b/tools/binman/etype/nxp_imx8mimage.py @@ -59,10 +98,52 @@ class Entry_nxp_imx8mimage(Entry_mkimage): + # 0x80 ... lookupTable + spidata += struct.pack('<I', 0x0818040b) + spidata += struct.pack('<I', 0x24043008)Just to check, this LUT is a single-pad fast-read sequence, so should we mention the fixed read command? E.g. if a board uses quad pads, what will happen.
Can you please rephrase this question ? I cannot make any sense of it. [...]
diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py @@ -8101,17 +8101,18 @@ fdt fdtmap Extract the devicetree blob from the fdtmap + self._DoTestFile('vendor/nxp_imx8m_fspi.dts') + self._DoTestFile('vendor/nxp_imx8m_fspi_pass.dts')Since binman now generates the header itself, please can you check the output data in the test, e.g. verify the tag at offset 0 and that the mkimage data starts at 0x1000? That would have caught the padding problem above. Also please use assertIn() on str(e.exception) for each failure case, so the test confirms the expected error rather than any ValueError.
Sure, if you can provide actual comprehensible example, I can add that. In the meantime, I skipped this and sent a V4.
