Hi Pranav,

On 2026-07-09T14:28:59, Pranav Sanwal <[email protected]> wrote:

> This series improves diagnosability of GPIO offset collisions in the
> uclass layer and fixes two related bugs in the gpio-delay driver that
> were uncovered while debugging such a collision.

Thanks for tracking this down.

One thing is missing, though: tests. The gpio-delay driver has no
sandbox coverage at all, which is presumably why these bugs went
unnoticed. Please can you add a gpio-delay node to the sandbox test
devicetree, wrapping at least two GPIO lines, along with a test in
test/dm/gpio.c that requests both consumers? That would have caught
the offset-propagation bug in patch 3 directly and would also
exercise the bounds check and array sizing from patch 2.

Regards,
Simon

Reply via email to