Hello Marek, Marek Vasut wrote: > Signed-off-by: Marek Vasut <[email protected]> > Cc: Stefano Babic <[email protected]> > Cc: Wolfgang Denk <[email protected]> > Cc: Detlev Zundel <[email protected]> > --- > arch/arm/include/asm/arch-mx28/regs-i2c.h | 203 > +++++++++++++++++++++++++++++ > 1 files changed, 203 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/include/asm/arch-mx28/regs-i2c.h
Patch looks good to me, but one minor comment: > diff --git a/arch/arm/include/asm/arch-mx28/regs-i2c.h > b/arch/arm/include/asm/arch-mx28/regs-i2c.h > new file mode 100644 > index 0000000..1bb20c3 > --- /dev/null > +++ b/arch/arm/include/asm/arch-mx28/regs-i2c.h > @@ -0,0 +1,203 @@ > +/* > + * Freescale i.MX28 I2C Register Definitions > + * > + * Copyright (C) 2011 Marek Vasut <[email protected]> > + * on behalf of DENX Software Engineering GmbH > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > + * > + */ > + > +#ifndef __REGS_I2C_H__ > +#define __REGS_I2C_H__ Please use here a more driver specific name, for example __MX28_REGS_I2C__ If you change that, you get my: Acked-by: Heiko Schocher<[email protected]> (I think, Stefano pick up the complete Patchserie, or?) bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
