Dear Torkel Lundgren, In message <[email protected]> you wrote: > Signed-off-by: Torkel Lundgren <[email protected]> > --- > include/configs/MPC8260ADS.h | 5 +++++ > include/configs/MPC8266ADS.h | 5 +++++ > include/configs/MPC8308RDB.h | 5 +++++ > include/configs/MPC8313ERDB.h | 5 +++++ > include/configs/MPC8315ERDB.h | 5 +++++ > include/configs/MPC8323ERDB.h | 5 +++++ > include/configs/MPC832XEMDS.h | 5 +++++ > include/configs/MPC8349EMDS.h | 5 +++++ > include/configs/MPC8349ITX.h | 5 +++++ > include/configs/MPC8360EMDS.h | 5 +++++ > include/configs/MPC8360ERDK.h | 5 +++++ > include/configs/MPC837XEMDS.h | 5 +++++ > include/configs/MPC837XERDB.h | 5 +++++ > include/configs/MPC8536DS.h | 5 +++++ > include/configs/MPC8540ADS.h | 5 +++++ > include/configs/MPC8541CDS.h | 5 +++++ > include/configs/MPC8544DS.h | 5 +++++ > include/configs/MPC8548CDS.h | 5 +++++ > include/configs/MPC8555CDS.h | 5 +++++ > include/configs/MPC8560ADS.h | 5 +++++ > include/configs/MPC8568MDS.h | 5 +++++ > include/configs/MPC8569MDS.h | 5 +++++ > include/configs/MPC8572DS.h | 5 +++++ > include/configs/MPC8610HPCD.h | 5 +++++ > include/configs/MPC8641HPCN.h | 5 +++++ > include/configs/MPC86xADS.h | 5 +++++ > include/configs/MPC885ADS.h | 5 +++++ > include/configs/PMC405.h | 5 +++++ > include/configs/PMC405DE.h | 5 +++++ > include/configs/Sandpoint8240.h | 5 +++++ > include/configs/Sandpoint8245.h | 5 +++++ > include/configs/at91sam9260ek.h | 5 +++++ > include/configs/at91sam9261ek.h | 5 +++++ > include/configs/at91sam9263ek.h | 5 +++++ > include/configs/integratorap.h | 5 +++++ > include/configs/integratorcp.h | 5 +++++ > include/configs/ixdp425.h | 5 +++++ > include/configs/ixdpg425.h | 5 +++++ > include/configs/microblaze-generic.h | 5 +++++ > include/configs/mpc8308_p1m.h | 5 +++++ > include/configs/mx31ads.h | 6 ++++++ > include/configs/mx31pdk.h | 6 ++++++ > include/configs/ocotea.h | 6 ++++++ > include/configs/omap1510inn.h | 5 +++++ > include/configs/omap5912osk.h | 5 +++++ > include/configs/ppmc7xx.h | 5 +++++ > include/configs/xilinx-ppc.h | 5 +++++ > 47 files changed, 238 insertions(+), 0 deletions(-)
You change a huge number of board configurations, without notifying the respective board maintainers. This is a bad idea in general. But in any case - what makes you think these boards would want to have this option enabled? I don't think they do. It increases the code size for a use case that is probably irrelevant to what appears to be the overwhelming majority of users. I recommend you leave it up to the board maintainers wether they want to enable this option or not. And BTW: CONFIG_BOOTM_OSE is completely undocumented. Could you please add the needed documentation first? And finally: > /* > + * BOOTM options > + */ > +#define CONFIG_BOOTM_OSE 1 Please never define any values for options that select features only, i. e. drop all these '1'. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man." - George Bernard Shaw _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
