Dear Andy Fleming, In message <cakwjmd5hgt9df76vpfs8b5sfqywoan1bgmt2vrihn0cta1b...@mail.gmail.com> you wrote: > > Shoot, I just saw this patch in my tree. It's incorrect.
Argh... > The lines weren't redundant. The logic is (and probably should be > better commented): > > Find the intersection of the advertised capabilities of both sides of > the link (lpa) > From that intersection, find the highest capability we can run at > (that will be the negotiated link) > > Now imagine that the intersection (lpa) is (LPA_100HALF | LPA_10FULL). > > The code will now set phydev->speed to 100, and phydev->duplex to 1, > but this link does not support 100FULL. Do we agree that I should revert this commit? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Felson's Law: To steal ideas from one person is plagiarism; to steal from many is research. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
