On Tuesday, October 04, 2011 08:35:10 AM Lei Wen wrote:
> Previous magic number is hard to parse its meaning, change it to
> respective macro definition
> 
> Signed-off-by: Lei Wen <[email protected]>

[..]

> --- a/include/mmc.h
> +++ b/include/mmc.h
> @@ -145,13 +145,15 @@
>  /*
>   * EXT_CSD fields
>   */
> -
> -#define EXT_CSD_PART_CONF    179     /* R/W */
> -#define EXT_CSD_BUS_WIDTH    183     /* R/W */
> -#define EXT_CSD_HS_TIMING    185     /* R/W */
> -#define EXT_CSD_CARD_TYPE    196     /* RO */
> -#define EXT_CSD_REV          192     /* RO */
> -#define EXT_CSD_SEC_CNT              212     /* RO, 4 bytes */
> +#define EXT_CSD_PARTITIONING_SUPPORT 160     /* RO */
> +#define EXT_CSD_ERASE_GROUP_DEF              175     /* R/W */
> +#define EXT_CSD_PART_CONF            179     /* R/W */
> +#define EXT_CSD_BUS_WIDTH            183     /* R/W */
> +#define EXT_CSD_HS_TIMING            185     /* R/W */
> +#define EXT_CSD_REV                  192     /* RO */
> +#define EXT_CSD_CARD_TYPE            196     /* RO */
> +#define EXT_CSD_SEC_CNT                      212     /* RO, 4 bytes */
> +#define EXT_CSD_HC_ERASE_GRP_SIZE    224     /* RO */
> 
>  /*
>   * EXT_CSD field definitions

Hi Lei,
this is better, but what about structure-based access ?

struct somrthing {
 u8 a1;
 u8 a2;
...
};

Like this.

Also, CC Andy.

Cheers
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to