On 10/06/2011 01:13 PM, Lukasz Majewski wrote:
> Hi Stefano,
>
Hi Lukasz,
> I suppose you are talking about cases like the following:
>
>> #define CONFIG_SPI_FLASH_CS (1 | 121 << 8)
>
> Yes, this construct will cause range overflow.
>
>> +struct p_spi {
>> + unsigned char cs;
>> + unsigned char mode;
>> + unsigned char bitlen;
>
> Therefore the above variables need to be at least unsigned shorts.
> As you proposed they shall be unsigned int.
Yes
>
> On technical question:
> Shall I prepare the whole v3 patch series or only v3 for this single
> patch ([PATCH v2 1/3] misc:pmic:core New generic PMIC drive)?
Post only v3 for the single patch.
>
> What would be easier for You or Wolfgang to pick?
As Wolfgang asked, I will take care of your patchset and I will merge it
with u-boot-imx. It will go into mainline after my pull request.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
