Hi Mike,
On 09.10.2011 19:56, Mike Frysinger wrote:
>> arm926ejs doesn't have {invalidate,flush}_dcache_range(), so we have to
>> add this not to break the driver on DaVinci boards (maybe we need to add
>> empty cache functions on arm926ejs instead?)
>
> if the prototype is in include/common.h, then code may assume it exists. if
> it doesn't exist for a particular cpu, then that cpu is broken and common
> code
> (which is what drivers/ is) should not be adding hacks to workaround broken
> cpus. please add stubs to the cpu you're referring to and drop the
> DAVINCI_EMAC_DCACHE define. or let whoever cares about that cpu add the
> defines, but still drop DAVINCI_EMAC_DCACHE.
Ok, I've dropped DAVINCI_EMAC_DCACHE (please see my v2 patches) but now
all DaVinci boards using this driver are broken...
Regards, Ilya.
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
