Hi Tom, On 18.10.2011 03:43, Tom Rini wrote: >> Don't hardcode u-boot.bin size for the case where mkimage signature is >> missing, use CONFIG_SYS_NAND_U_BOOT_SIZE for this. >> >> Signed-off-by: Ilya Yanok <[email protected]> > > I don't like this since it means we need to always define this > variable when well behaved situations will have shipped u-boot.img > anyhow. Or is there really a good reason > to fall back to u-boot.bin?
No, I don't think so. I got your point. Still I think hardcoding the size value is not very good solution either. Maybe we can add something like #ifndef CONFIG_SYS_NAND_U_BOOT_SIZE #define CONFIG_SYS_NAND_U_BOOT_SIZE (200 * 1024) /* 200kB - default */ #endif ? Regards, Ilya. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
