Dear Simon Glass,

In message <[email protected]> you wrote:
> We want to show block markers on completion of get and put, so
> move this common code into separate functions.
> 
> Signed-off-by: Simon Glass <[email protected]>
> ---
>  net/tftp.c |   68 +++++++++++++++++++++++++++++++++--------------------------
>  1 files changed, 38 insertions(+), 30 deletions(-)

ARRRRRRGHHH!!!!

Your commits are not bisectable.

When applying your commits up to and including this one, all boards
with ethernet support will break with errors like this:


net.c: In function 'NetLoop':
net.c:412: error: too many arguments to function 'TftpStart'
make[1]: *** [/work/wd/tmp-ppc/net/net.o] Error 1


Please always make sure that patches are really orthogonal so we can
use git bisect!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
War is never imperative.
        -- McCoy, "Balance of Terror", stardate 1709.2
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to