On Thu, Nov 10, 2011 at 5:49 PM, Ilya Yanok <ya...@emcraft.com> wrote: > Hi Tom, > > I've just posted the updated patches, please consider merging them. > ( http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/116535 ) > > On 07.11.2011 04:14, Tom Rini wrote: >> >> I'm not sure what we should do about this series right now. Aside >> >> from some "easily" fixable things like all of the PHY files needing an >> >> ugly #include "../../../../../drivers/net/davinci_emac.h" to compile > > I've fixed PHY files to include this. > >> >> again and a CONFIG_SYS_CACHELINE_SIZE 32 in all of the platforms, the >> > >> > s/CONFIG_SYS_CACHELINE_SIZE/ARCH_DMA_MINALIGN/ should solve this >> problem. I'll fix this. >> >> Thanks. > > Fixed. > >> >> lack of flush functions means that MAKEALL -s davinci fails for almost >> >> every board now. I'm not sure what we should do, at this point... >> > >> > Argh.. Actually my initial version had a workaround for this, only >> using {flush,invalidate}_dcache_range under #ifdef DAVINCI_EMAC_DCACHE >> clause... But Mike told me that I should remove this... >> > >> > Maybe we can just add empty functions for CONFIG_DCACHE_OFF case to >> fix the compilation? > > Added no-op cache functions for arm926ejs. However many DaVinci boards > are still broken as suprisingly they have D-Cache enabled (I wonder if > EMAC works on these boards).
Given how quick builds are now, what's MAKEALL -s davinci look like, before/after? Or did you mean EMAC functions not just builds? That's another question which I've had a few conversations with people about (and I've got a TODO list item to poke the kernel about how it does cache flushing/etc here, but it also probably relies on page stuff we don't do..). Thanks! -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot