Dear Tapani Utriainen, In message <20111121165205.4624b13b@myhost> you wrote: > > Add support for TechNexion TDM3730 SoM
Please use a better Subject: and add a bit more of information to the commit message itself. > Signed-off-by: Tapani Utriainen <[email protected]> > CC: Sandeep Paulraj <[email protected]> > --- > board/technexion/tdm3730/Makefile | 49 ++++ > board/technexion/tdm3730/tdm3730.c | 173 ++++++++++++++++ > board/technexion/tdm3730/tdm3730.h | 383 > +++++++++++++++++++++++++++++++++++++ > boards.cfg | 1 > include/configs/tdm3730.h | 360 ++++++++++++++++++++++++++++++++++ > 5 files changed, 966 insertions(+) Same comments as before, entry to MAINTAINERS missing, etc, etc, > --- /dev/null > +++ b/board/technexion/tdm3730/tdm3730.c > @@ -0,0 +1,173 @@ > +/* > + * TechNexion, <www.technexion.com> > + * > + * Maintainer : > + * Tapani Utriainen <[email protected]> This belongs into the MAINTAINERS file. ... > +#define CONFIG_EXTRA_ENV_SETTINGS \ It appears the environment settings on these boards are pretty much similar (which certainly makes sense). Please consider factoring out these common parts into a separate header file instead of repeating them all over. > +#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800 > +#define CONFIG_SYS_INIT_RAM_SIZE 0x800 Has this been tested? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] Time is an illusion perpetrated by the manufacturers of space. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
