Hi, 2011/10/17 Marek Vasut <[email protected]>: > On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote: >> Signed-off-by: Stefan Herbrechtsmeier <[email protected]> >> CC: Marek Vasut <[email protected]> >> CC: Remy Bohmer <[email protected]> >> --- > > Hi Stefan, > > this patch is awesome, I really need this one. But ... > > Can you possibly convert the register definitions to struct based access ? > > Like > > struct pxa_usb_regs { > u32 reg1; > u32 reg2; > ... > }; > > and then use it in the functions : > > type fn() > { > struct pxa_usb_regs regs = (struct pxa_usb_regs)0x46000000; > ... > writel(val, ®s->reg1); > }
I agree with this remark, but I think this should be done in a different patch. So, I applied it to u-boot-usb as-is. Kind regards, Remy _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
