Hi Stefan, 2011/11/28 Stefan Herbrechtsmeier <[email protected]>: > Am 26.11.2011 23:25, schrieb Remy Bohmer: > >> 2011/10/17 Stefan Herbrechtsmeier<[email protected]>: >>> >>> On some usb device controllers (pxa) the endpoint configuration must be >>> programmed prior to enable it. >>> >>> Signed-off-by: Stefan Herbrechtsmeier<[email protected]> >>> CC: Marek Vasut<[email protected]> >>> CC: Remy Bohmer<[email protected]> >>> --- >>> drivers/serial/usbtty.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> Applied to u-boot-usb > > I was surprised that the patch was applied without comments as it change the > usbtty core > behaviour and has the possibility to break other drivers.
I was not really surprised ;-) Looking at the code it seemed to me that it was indeed cleaner to initialize the endpoints before enabling them. That you have problems on your board confirmed that. So, to me this was a plain bugfix. > Should I CC the affected driver and board maintainer to hopefully get some > feedback? This would not harm at all. I did not ask Wolfgang to pull the u-boot-usb tree yet, so it is not in mainline yet. I need to do some more testing on the current u-boot-usb tree as well. So, if more people look at it, it would be a good thing. Kind regards, Remy _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
