Hi Anton, On 30/11/11 10:39, Gabe Black wrote: > The ALLOC_CACHE_ALIGN_BUFFER macro allocates a pointer to a buffer, and the > address of the pointer and not the buffer was being passed to a function > that expected the other. This change fixes a few places that bug crops up. > Also, it provides a default definition for the CONFIG_SYS_CACHELINE_SIZE > macro to avoid compiler errors. > > Signed-off-by: Gabe Black <[email protected]> > --- > disk/part_efi.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/disk/part_efi.c b/disk/part_efi.c > index e7f2714..c94d808 100644 > --- a/disk/part_efi.c > +++ b/disk/part_efi.c > @@ -37,6 +37,10 @@ > #include "part_efi.h" > #include <linux/ctype.h> > > +#ifndef CONFIG_SYS_CACHELINE_SIZE > +#define CONFIG_SYS_CACHELINE_SIZE __BIGGEST_ALIGNMENT__ > +#endif > + > #if defined(CONFIG_CMD_IDE) || \ > defined(CONFIG_CMD_MG_DISK) || \ > defined(CONFIG_CMD_SATA) || \ > @@ -130,7 +134,7 @@ void print_part_efi(block_dev_desc_t * dev_desc) > } > /* This function validates AND fills in the GPT header and PTE */ > if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA, > - &(gpt_head), &gpt_pte) != 1) { > + gpt_head, &gpt_pte) != 1) { > printf("%s: *** ERROR: Invalid GPT ***\n", __func__); > return; > } > @@ -169,7 +173,7 @@ int get_partition_info_efi(block_dev_desc_t * dev_desc, > int part, > > /* This function validates AND fills in the GPT header and PTE */ > if (is_gpt_valid(dev_desc, GPT_PRIMARY_PARTITION_TABLE_LBA, > - &(gpt_head), &gpt_pte) != 1) { > + gpt_head, &gpt_pte) != 1) { > printf("%s: *** ERROR: Invalid GPT ***\n", __func__); > return -1; > }
This appears to be a fix for your "part_efi: dcache: allocate cacheline aligned buffers" commit - Can you have a look at it please? If you ack, I will apply to staging Regards, Graeme _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
