Dear Gerlando Falauto, In message <4ee60729.4020...@keymile.com> you wrote: > > > Run checkpatch, and mind the CodingStyle section about typedefs! > > I did run checkpatch, it didn't say a word about this.
If you add new tyedef's, it will complain. > What is your recommendation about typedef'ining a function pointer? > I immediately suspected that using a callback function might sound like > heresy, so if you have any better suggestion please put it forward > before I rework this changeset for the fifth time... please. Sorry, I'm in the middle of -rc1 release work and testing, and also right in the final steps of releasing the next version of our ELDK (v5.1). Plus a few other tasks, including trips to customers. I don't have time for a thorough review now. I understand this is very bad for you, but I cannot change it. > I just think having the whole, expanded signature as the type for a > function-pointer parameter or local variable would just make things too > long and redundant. Hm... probbaly. > Just off the top of my head: perhaps a struct with a single function > pointer element might look better than a typedef? I'm not convinced. I'd have to see the code, and compare. But to do so, I'd need a bit of time... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A supercomputer is a machine that runs an endless loop in 2 seconds. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot