On 2011년 12월 13일 15:15, Aaron Williams wrote: > On Thursday, October 27, 2011 02:10:58 PM Wolfgang Denk wrote: >> Commit c30a15e "FAT: Add FAT write feature" introduced a compiler >> warning. Fix this. >> >> Signed-off-by: Wolfgang Denk <[email protected]> >> Cc: Donggeun Kim <[email protected]> >> Cc: Kyungmin Park <[email protected]> >> --- >> >> fs/fat/fat.c | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/fs/fat/fat.c b/fs/fat/fat.c >> index 7cf173c..756ac64 100644 >> --- a/fs/fat/fat.c >> +++ b/fs/fat/fat.c >> @@ -46,7 +46,6 @@ static void downcase (char *str) >> static block_dev_desc_t *cur_dev = NULL; >> >> static unsigned long part_offset = 0; >> -static unsigned long part_size; >> >> static int cur_part = 1; >> >> @@ -100,7 +99,6 @@ int fat_register_device (block_dev_desc_t * dev_desc, >> int part_no) if (!get_partition_info(dev_desc, part_no, &info)) { >> part_offset = info.start; >> cur_part = part_no; >> - part_size = info.size; >> } else if ((strncmp((char *)&buffer[DOS_FS_TYPE_OFFSET], "FAT", 3) == 0) >> || (strncmp((char *)&buffer[DOS_FS32_TYPE_OFFSET], "FAT32", 5) == 0)) { /* >> ok, we assume we are on a PBR only */ > > Hi Wolfgang, > > I know it's rather late to comment on this, but this patch breaks FAT write > support. > > -Aaron > > Hi, Wolfgang,
I've overlooked the patch before. If 'part_size' variable is not set in fat_register_device function, FAT write feature would not work properly. So, I will send a patch to define the variable only when FAT_WRITE is enabled. It can avoid compile warning. Thanks. -Donggeun _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
