On 15/12/2011 23:07, Fabio Estevam wrote:
> Let dram_init function be a common function, so that other mx28 boards
> can reuse it.
>
> Signed-off-by: Fabio Estevam <[email protected]>
> ---
> -int board_init(void)
> +int dram_init(void)
> {
> - /* Adress of boot parameters */
> - gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
> -
> + mx28_dram_init();
> return 0;
Why not simply return mx28_dram_init() ?
We do not drop the return code if mx28_dram_init will be changed.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot