On Saturday 10 December 2011 16:07:53 Simon Glass wrote: > --- /dev/null > +++ b/include/bootstage.h > > +/* > + * This file implements recording of each stage of the boot process. It is > + * intended to implement timing of each stage, reporting this information > + * to the user and passing it to the OS for logging / further analysis. > + */
maybe it's me, but i'd expect this at the top of the file before the
copyright/license notice
>
> + * progres action1
typo ? shows up a few times ...
> +enum bootstage_id {
> + BOOTSTAGE_ID_RUN_OS = 15, /* Exiting U-Boot, entering OS */
> +};
what relevance does this # have ? since it gets passed to Linux, it becomes
part of the ABI and cannot be changed, so that should be mentioned in the
comment.
> +/*
> + * Board-specific platform code can implement show_boot_progress () if
"board-specific platform" is kind of redundant
also, no space before "()"
> --- a/include/common.h
> +++ b/include/common.h
> @@ -801,10 +801,8 @@ int pcmcia_init (void);
> #ifdef CONFIG_STATUS_LED
> # include <status_led.h>
> #endif
> -/*
> - * Board-specific Platform code can reimplement show_boot_progress () if
> needed - */
> -void show_boot_progress(int val);
> +
> +#include <bootstage.h>
>
> /* Multicore arch functions */
> #ifdef CONFIG_MP
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
