Hi Mike, On Fri, Jan 20, 2012 at 10:54 AM, Mike Frysinger <vap...@gentoo.org> wrote: > On Tuesday 10 January 2012 19:45:45 Simon Glass wrote: >> This adds support for a controlling fdt, mirroring the ARM implementation. > > OK, but what's the point if we aren't doing FDT's ?
Aren't we? I hope that sandbox provides a way of testing the FDT stuff. I used it for the fdtdec alias stuff which was complicated enough that it needed unit tests. We need to enable these options to bring in that code, even if we don't actually have a run-time FDT yet. > >> +#ifdef CONFIG_OF_EMBED >> + /* Get a pointer to the FDT */ >> + gd->fdt_blob = _binary_dt_dtb_start; >> +#elif defined CONFIG_OF_SEPARATE >> + /* FDT is at end of image */ >> + gd->fdt_blob = (void *)(_end_ofs + _TEXT_BASE); >> +#endif > > i'd be inclined to do: > +#if defined(CONFIG_OF_EMBED) > ... > +#elif defined(CONFIG_OF_SEPARATE) > ... > +#endif OK done. Regards, Simon > -mike _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
