Re: [U-Boot] [PATCH 1/2] da850evm: add support to read mac address from spi flash

[Mike Frysinger]

On Thursday 02 February 2012 08:42:17 Manjunath Hadli wrote:
> --- a/board/davinci/da8xxevm/da850evm.c
> +++ b/board/davinci/da8xxevm/da850evm.c
>
>  int misc_init_r(void)
>  {
>       dspwake();
> +
> +#ifdef CONFIG_MAC_ADDR_IN_SPIFLASH
> +     uchar buff[8];
> +     int ret;
> +
> +     if (!eth_getenv_enetaddr("ethaddr", buff)) {
> +             ret = get_mac_addr(buff);
> +             if (ret != 0)
> +                     return -EINVAL;
> +
> +             if (!is_valid_ether_addr(buff)) {
> +                     printf("Invalid MAC address read.\n");
> +                     return -EINVAL;
> +             }
> +
> +             eth_setenv_enetaddr("ethaddr", buff);
> +     }
> +#endif

i don't think you should return -EINVAL here.  just issue the warning and be 
done with it.
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot