Hi Stephen, On Mon, Jan 23, 2012 at 10:25 AM, Stephen Warren <swar...@nvidia.com> wrote: > On 01/22/2012 10:41 AM, Simon Glass wrote: >> Hi Stephen, >> >> On Thu, Jan 19, 2012 at 12:51 PM, Stephen Warren <swar...@nvidia.com> wrote: >>> On 01/12/2012 12:00 PM, Simon Glass wrote: >>>> Add U-Boot's peripheral clock information to the Tegra20 device tree file. >>> >>>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi >>>> index ca7b523..963cf27 100644 >>>> --- a/arch/arm/dts/tegra20.dtsi >>>> +++ b/arch/arm/dts/tegra20.dtsi >>>> @@ -45,6 +45,8 @@ >>>> compatible = "nvidia,tegra20-i2c"; >>>> reg = <0x7000C000 0x100>; >>>> interrupts = < 70 >; >>>> + clock-frequency = <100000>; >>> >>> That's board-specific information. I'd rather not include it in the SoC >>> .dtsi file even as a default; that way, it forces people to think about >>> the correct value and put it in their board file, whereas including a >>> default means people probably won't think about it. >> >> OK I moved this into the board file - sadly this means everyone will >> need to specify it here. Or should we have a default? > > I think I'd rather not have the default. That way, people need to think > about the correct value to use in their board file, rather than having > it magically work without having validated the value. > > If people disagree, we'd need to update the kernel's tegra[23]0.dtsi, > since they assume ${board}.dts will set this property.
OK that's fine with me. Regards, Simon > > -- > nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot