On Mon, Feb 6, 2012 at 5:12 PM, Igor Grinberg <grinb...@compulab.co.il> wrote: > On 02/03/12 15:38, Govindraj.R wrote: >> From: "Govindraj.R" <govindraj.r...@ti.com> >> >> Adding ehci clock enabling mechanism part of clock framework. >> When essential clocks are enabled during init phase usb host >> clocks can also be enabled from clock framework. >> >> Signed-off-by: Govindraj.R <govindraj.r...@ti.com> > > Acked-by: Igor Grinberg <grinb...@compulab.co.il> > >> --- >> arch/arm/cpu/armv7/omap3/board.c | 4 ++++ >> arch/arm/cpu/armv7/omap3/clock.c | 20 ++++++++++++++++++++ >> arch/arm/cpu/armv7/omap4/clocks.c | 5 +++++ >> arch/arm/include/asm/arch-omap3/sys_proto.h | 1 + >> 4 files changed, 30 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/cpu/armv7/omap3/board.c >> b/arch/arm/cpu/armv7/omap3/board.c >> index 871aa37..054e9c4 100644 >> --- a/arch/arm/cpu/armv7/omap3/board.c >> +++ b/arch/arm/cpu/armv7/omap3/board.c >> @@ -228,6 +228,10 @@ void s_init(void) >> >> per_clocks_enable(); >> >> +#ifdef CONFIG_USB_EHCI_OMAP >> + ehci_clocks_enable(); >> +#endif > > Just a question (not blocking): > I would really like to see this being a part of "usb start" call some day... > Can't this be called from omap_ehci_hcd_init()?
But its better to have it part of clock framework. on omap4 I have added this part of enabling essential clocks done part of clock framework. "arch/arm/cpu/armv7/omap[4/5]/clocks.c" => "arch/arm/cpu/armv7/omap-common/clocks-common.c" but on omap3 we don't seem to use clocks common. so I have just used this function. on omap4/5 clocks.c makes things simpler for us. (re-use the same rather to complicate with our funcs) -- Thanks, Govindraj.R _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot