Hi, Hello. Thanks for your review. I resend revised patch with your Acked-by.
Best regards, Nobuhiro 2012/2/15 Heiko Schocher <[email protected]>: > Hello Nobuhiro, > > Nobuhiro Iwamatsu wrote: >> This provide bit control functions as clrbits_*, setbits_* and >> clrsetbits_*. >> >> Signed-off-by: Nobuhiro Iwamatsu <[email protected]> >> --- >> arch/sh/include/asm/io.h | 37 +++++++++++++++++++++++++++++++++++++ >> 1 files changed, 37 insertions(+), 0 deletions(-) > > Beside one minor comment: > > Acked-by: Heiko Schocher <[email protected]> > >> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h >> index ca598a6..79cb098 100644 >> --- a/arch/sh/include/asm/io.h >> +++ b/arch/sh/include/asm/io.h >> @@ -237,6 +237,43 @@ static inline void sync(void) >> { >> } >> >> + >> +/* Clear and set bits in one shot. These macros can be used to clear and > > Wrong comment style, please fix. > > [...] > > bye, > Heiko > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > _______________________________________________ > U-Boot mailing list > [email protected] > http://lists.denx.de/mailman/listinfo/u-boot -- Nobuhiro Iwamatsu _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
