On Monday 05 March 2012 16:11:08 Marek Vasut wrote:
> +get_target_location() {
> + target=$1
> +
> + BOARD_NAME=""
> + CONFIG_NAME=""
> + board=""
> + vendor=""
please use "local" when declaring variables that are function local
> + line=`egrep -i "^[[:space:]]*${target}[[:space:]]" boards.cfg`
obviously i prefer $(...) rather than `...`
> + if [ -z "${line}" ] ; then echo "" ; return ; fi
please unroll
> + [ "${BOARD_NAME}" ] || BOARD_NAME="${1%_config}"
: ${BOARD_NAME:=${1%_config}}
> + [ $# -gt 6 ] && [ "$7" != "-" ] && {
please use:
if ... ; then
> + if ! grep -i ${name} MAINTAINERS >/dev/null 2>&1 ; then
use -qs and then you can drop the redirects
> + return ;
drop the semi-colon
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
