On 05/22/2012 03:15 PM, Marc Dietrich wrote: > On Tuesday 22 May 2012 10:58:37 Stephen Warren wrote: >> On 05/22/2012 10:14 AM, Stephen Warren wrote: >>> On 05/22/2012 02:04 AM, Marc Dietrich wrote: >>>> Hi Stephen, >>>> >>>> Am Montag, 21. Mai 2012, 14:04:37 schrieb Stephen Warren: >>>>> From: Stephen Warren <swar...@nvidia.com> >>>>> >>>>> ... to enable USB host support, which enables Ethernet support. >>>>> >>>>> Signed-off-by: Stephen Warren <swar...@nvidia.com> >>>> >>>> while adding usb support is fine, I see no reason to add smsc95xx support >>>> because contrary to harmony, paz00 does not contain an ethernet port. >>> >>> Is the SMSC95xx only an internal part, or could it be present on a >>> user-pluggable USB dongle? I wasn't sure, so I left it in. >> >> Looking at the driver (and the Linux kernel driver and SMSC's website), >> it supports both the standalone USB->Ethernet 9500 chip that's likely to >> be in USB Ethernet dongles, and various combo USB hub + Ethernet chips >> that are found on motherboards (e.g. Harmony). As such, I think it's >> reasonable to leave this config option enabled on Paz00 and other Tegra >> boards even when such a chip isn't on the board itself. Do you agree? > > Following this argument would mean to enable all current (and future) usb > devices and we end up with an u-boot which is to heavy to swim. I only have a > mcs7830 which is unfortunately not supported. Do you have a SMSC95xx based > usb > adapter or plan to get one? In this case I think it would be ok to enable it, > otherwise I tend to disagree here. On the other hand, given that you kindly > take care of the paz00 code, the decision is up to you.
Mine is an Asix-based dongle. It seems a pity to artificially limit ourselves. I'd be happy seeing all the USB devices enabled as the drivers are written myself. But I suppose net-booting is a developer thing, and developers can easily turn on this option if they want, so I can remove it. Is your objection for the Paz00 board only? I turned it on for all the other boards too. Note that Harmony really does have this chip on the board, so would need this option enabled either way. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
