> -----Original Message----- > From: Valentin Longchamp [mailto:[email protected]] > Sent: 04 June 2012 21:07 > To: Marek Vasut > Cc: Prafulla Wadaskar; [email protected]; Holger Brunck > Subject: Re: [PATCH] Kirkwood: Add support for Ka-Ro TK71 > > Hi Marek and Prafulla, > > On 06/01/2012 03:03 PM, Marek Vasut wrote: > > Dear Prafulla Wadaskar, > > > >>> -----Original Message----- > >>> From: Marek Vasut [mailto:[email protected]] > >>> Sent: 31 May 2012 16:37 > >>> To: [email protected] > >>> Cc: Marek Vasut; Prafulla Wadaskar; Wolfgang Denk > >>> Subject: [PATCH] Kirkwood: Add support for Ka-Ro TK71 > >>> > >>> Signed-off-by: Marek Vasut <[email protected]> > >>> Cc: Prafulla Wadaskar <[email protected]> > >>> Cc: Wolfgang Denk <[email protected]> > >>> --- > >>> > >>> board/karo/tk71/Makefile | 45 ++++++++++ > >>> board/karo/tk71/kwbimage-256.cfg | 174 > >>> > >>> ++++++++++++++++++++++++++++++++++++++ > >>> > >>> board/karo/tk71/kwbimage-512.cfg | 174 > >>> > >>> ++++++++++++++++++++++++++++++++++++++ > >> > >> Dear Marek > >> Just for DRAM size change do not add one more cfg file, configure > by > >> default 256MB of RAM in default kwbimg.cfg file and in function > >> board_early_init_f() tune it to 512 for your other board version. > > > > There's only one single bit flipped between those two kwb configs. > Do you think > > it'd work if we just configured the system for 512MB RAM and ran > get_ram_size() > > to see if it has only 256MB? That'd eliminate two board entries for > this tk71. > > > > I would like to have your advice on this as well Prafulla. > > We have tested this on km_arm (we will have the same boards with 1/2 > the RAM > size) and with the above get_ram_size() it works as expected. > > We still should, however, at some point (board_early_init_f() is a > good > candidate) then reduce the corresponding RAM CS size (reg @1504 for > CS0 so that > the window is the same size as what was detected by get_ram_size). > What do you > guys think ?
Dear Valentin Yes, we should use this method. That's why I always ask if one can reuse any existing kwbimage.cfg. It makes no sense to add one more file of 250 lines just for one or two difference/s that can be handled through board_early_init_f(). Regards.. Prafulla . . . _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
