On 06/02/2012 01:38 PM, Stijn Souffriau wrote:
> ---
> tools/mkimage.h | 6 ++++++
> tools/ublimage.c | 29 +++++++++++++++++++++++++++--
> tools/ublimage.h | 2 ++
> 3 files changed, 35 insertions(+), 2 deletions(-)
In addition to what I just said about v2, v3 and so forth (and needing a
body of the commit message, in this case explain what PLL mode is and so
forth), you have a few cases of '//' or:
/* multi line
* comments.
*/
that don't match the required style. Using checkpatch.pl should catch
one or both of these cases.
[snip]
> + {UBL_MAGIC_SAFE,"safe", "Safe boot mode", },
> + {UBL_MAGIC_PLL, "pll", "With PLL enabled to have higher ARM/DMA
> clocks", },
Missing space. Thanks!
--
Tom
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
