> -----Original Message----- > From: [email protected] [mailto:u-boot- > [email protected]] On Behalf Of Dirk Behme > Sent: 11 July 2012 12:23 > To: [email protected]; Joe Hershberger > Subject: Re: [U-Boot] [PATCH V2 1/1] net: phy: micrel: make ksz9021 > phy accessible > > On 11.07.2012 02:53, Troy Kisky wrote: > > On 6/28/2012 11:00 AM, Troy Kisky wrote: > >> Micrel accidentally used the same part number > >> for the KS8721 and KSZ9021. So, both cannot be > >> in the same build of u-boot. Add a config option > >> to handle this. > >> > >> Signed-off-by: Troy Kisky <[email protected]> > >> Acked-by: Vladimir Zapolskiy <[email protected]> > >> > >> --- > >> v2: add ack > >> --- > >> drivers/net/phy/micrel.c | 15 +++++++++++++-- > >> include/configs/mx6qsabrelite.h | 1 + > >> 2 files changed, 14 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > >> index e3043df..30f3264 100644 > >> --- a/drivers/net/phy/micrel.c > >> +++ b/drivers/net/phy/micrel.c > >> @@ -35,6 +35,12 @@ static struct phy_driver KSZ804_driver = { > >> .shutdown = &genphy_shutdown, > >> }; > >> > >> +#ifndef CONFIG_PHY_MICREL_KSZ9021 > >> +/* > >> + * I can't believe Micrel used the exact same part number > >> + * for the KSZ9021 > >> + * Shame Micrel, Shame!!!!!
These comments attracted my attention. I doubt these are valid comments that should get mainlined??? Regards... Prafulla . . . _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
