Hi!
> > > > + writel(TIMER_LOAD_VAL, &timer_base->load_val);
> > > > + writel(TIMER_LOAD_VAL, &timer_base->curr_val);
> > > > + writel((readl((&timer_base->ctrl)) | 0x3),
> > >
> > > I think you should stick to programming in C here, not ((((LISP)))), so
> > > try cutting down on the ((braces)) :-)
> >
> > Some braces have been harmed by creation of this patch.
>
> At least one more pair must be killed on the above statement :)
I removed two pairs but failed to post the patch ;-). Be sure you'll
never see them again.
> > > btw. what's this 0x3 magic constant ?
> >
> > Dinh has to help here :-(.
>
> Also, use setbits_le32() there instead anyway.
Uff, setbits_le32 looks seriously strange. Should I do this?
Thanks for review,
Pavel
diff --git a/arch/arm/cpu/armv7/socfpga/timer.c
b/arch/arm/cpu/armv7/socfpga/timer.c
index 79fa081..1ceb6e9 100644
--- a/arch/arm/cpu/armv7/socfpga/timer.c
+++ b/arch/arm/cpu/armv7/socfpga/timer.c
@@ -30,7 +30,7 @@ int timer_init(void)
{
writel(TIMER_LOAD_VAL, &timer_base->load_val);
writel(TIMER_LOAD_VAL, &timer_base->curr_val);
- writel(readl(&timer_base->ctrl) | 0x3, &timer_base->ctrl);
+ setbits_le32(&timer_base->ctrl, 0x3);
return 0;
}
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
