On 09/02/2012 10:45 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <[email protected]> you 
> wrote:
>> From: Stephen Warren <[email protected]>
>>
>> Each EFI partition table entry contains a UUID. Extend U-Boot's struct
>> disk_partition to be able to store this information, and modify
>> get_partition_info_efi() to fill it in.
>>
>> The implementation of uuid_string() was stolen from the Linux kernel.
>>
>> Signed-off-by: Stephen Warren <[email protected]>
> 
> Can we please make this addition dependent on EFI support being
> enabled?  Otherwise the increased memory footprint will hit all users,
> even if they never use EFI at all.

(I assume you're talking about the change to the partition info
structure, since IIRC all the other code was already in either the EFI
partition code already, or a new command under its own ifdef).

I'm also planning a patch that fills in this UUID field for MBR/DOS
partition tables too. That'd require the ifdef to check 2 different
config symbols, and perhaps more in the future. It seems a little messy
to ifdef this just to save 4 bytes. Are you sure you want to do this?

_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to