Dear Pavel Herrmann, > On Monday 03 of September 2012 18:49:00 Marek Vasut wrote: > > > + > > > +static const char revision[] = "0.0"; > > > +static const char vendor[] = "SATA loopback"; > > > + > > > +static const char * const filenames[] = CONFIG_SATA_LOOP_DISKS; > > > +static int max_devs = CONFIG_SYS_SATA_MAX_DEVICE; > > > > One more thing is missing -- documentation for these (add to doc/ ). > > which file shoud that be exactly? README.sata has nothing about configs, i > cannot find any README.sandbox or README.configs
Create one ... especially for the newly added feature -- eg. README.sata_loopback or something, > > Alternatively (which would be much better), let sandbox uboot accept > > params and supply these as params. > > or even make a command that would allow you to specify a filename in > runtime, possibly with a dynamic number of ports. Good idea, indeed. > Pavel Herrmann Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
