On 27/09/2012 23:43, Benoît Thébaudeau wrote: > Hi Fabio, > > On Thursday, September 27, 2012 10:55:22 PM, Fabio Estevam wrote: >> Hi Benoît, >> >> On Thu, Sep 27, 2012 at 5:28 PM, Benoît Thébaudeau >> <benoit.thebaud...@advansee.com> wrote: >>> The FEC is the only SoC Ethernet support available on i.MX25, so >>> define >>> cpu_eth_init() only for it instead of returning a misleading >>> success code. >> >> Yes, but someone may want to use mx25 with a external LAN device >> (such >> as LAN92xx) instead of FEC. > > Yes, but in that case I think that there should be a board_eth_init() function > defined, so this patch won't cause any trouble here. See in > net/eth.c:eth_initialize() how these functions and their default > implementations > are handled.
I think also that in this case a board_eth_init() must be used - the #ifdef in cpu_eth_init() is then superflous. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
