Re: [U-Boot] [PATCH] powerpc/fm: fix TBI PHY address settings

[Xie Shaohui-B21989]

> Xie Shaohui-B21989 wrote:
> 
> >> Is this still true with Fman v3?
> > [S.H] No. Fman V3 does not need to set TBIPA on FM1@DTSEC1.
> 
> Does this patch break Fman V3?

[S.H] No. Fman V3 uses following code:

static void dtsec_init_phy(struct eth_device *dev)
 {
        struct fm_eth *fm_eth = dev->priv;
-       struct dtsec *regs = (struct dtsec *)fm_eth->mac->base;
 
+#ifndef CONFIG_SYS_FMAN_V3
+       struct dtsec *regs = (struct dtsec *)fm_eth->mac->base;
        /* Assign a Physical address to the TBI */
        out_be32(&regs->tbipa, CONFIG_SYS_TBIPA_VALUE);
+#endif
 
        if (fm_eth->enet_if == PHY_INTERFACE_MODE_SGMII)
                dtsec_configure_serdes(fm_eth);

The whole patch which introduced Fman V3 is at link:
http://patchwork.ozlabs.org/patch/190087/
Andy will need to merge the codes when he pick the two patches.


Best Regards, 
Shaohui Xie

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot