Hi, On Sat, Nov 3, 2012 at 2:11 PM, Simon Glass <s...@chromium.org> wrote: > Hi Wolfgang, > > On Sat, Nov 3, 2012 at 8:04 AM, Wolfgang Denk <w...@denx.de> wrote: >> Dear Simon Glass, >> >> In message >> <CAPnjgZ2hD4ZgzM=0rppsgr0-iojtv+q40e3gyexeqxndkop...@mail.gmail.com> you >> wrote: >>> >>> >> > --- /dev/null >>> >> > +++ b/common/cmd_cbfs.c >>> >> > @@ -0,0 +1,214 @@ >>> >> > +/* >>> >> > + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. >>> >> > + * >>> >> > + * See file CREDITS for list of people who contributed to this >>> >> > + * project. >>> >> >>> >> file CREDITS ? Please fix globally... >>> >> >>> >> >>> >> Is any of this code taken from any other project? If yes, then please >>> >> attribute properly... >>> > >>> > Sorry? U-Boot has a CREDITS file but only ~10% of the files reference >>> > it. >> >> Yes, U-Boot has such a file, and I wonder if we should remove it. >> After all, all the credits are maintained in the git history of >> changes. >> >>> Tom or Wolfgang, can you please explain what I should do here? I don't >>> know what to do about the CREDITS line. >> >> To me the reference to a CREDITS file is reason to suspect that this >> code has not been written from scratch, but copied from some other >> project, which eventually had it's own CREDITS file. > > Yes, quite likely the boilerplate came from another U-Boot file. > >> >> I'm missing a reference to the origin of the code. > > It was written from scratch by Gabe - it did not come from coreboot if > that is what you as asking. I confirmed with him again yesterday. > >> >> If this was indeed written from scratch, with no code borrowed from >> elsewhere, then please just drop these lines. > > OK, I will do this in my follow-up patch to add DocBook support. I did > find a shorter message which some U-Boot files use at one point. I > will try to find that again, and use it.
Well I found a very short version: * Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. but it is inaccurate. We could perhaps change it to: * Use of this source code is governed by a BSD-style license that can be * found in the COPYING file. or something similar? But so much of U-Boot already has the full version that I'm not sure this is a good idea. Here is the one I am using> # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as # published by the Free Software Foundation; either version 2 of # the License, or (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, write to the Free Software # Foundation, Inc., 59 Temple Place, Suite 330, Boston, # MA 02111-1307 USA So for now I have sent a new patch that just takes out the CREDITS but leaves the rest of the text in. Please advise if something else is needed/preferable. Regards, Simon >> >> Best regards, >> >> Wolfgang Denk >> >> -- >> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de >> "Text processing has made it possible to right-justify any idea, even >> one which cannot be justified on any other grounds." >> -- J. Finnegan, USC. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot