Hi Anirudh, On 2026-07-19T18:03:31, Anirudh Srinivasan <[email protected]> wrote:
> Patches 1-5 contain misc fixes to drivers/bios_emulator that are > suitable for upstream. I would like to get these reviewed and merged in > if possible. > > Patches 6, 7, 8 are an implementation of how I got u-boot to actually > talk to to the Aspeed VGA card. Thanks for looking at this. Please can you split this into two submissions? Patches 1-5 stand on their own; mixing them with the NOT-FOR-UPSTREAM material makes it awkward to pick up what is ready. Send the RFC portion as its own series marked [RFC] in the subject. On the design: I suspect the right shape is a driver-specific hook rather than open-coding Aspeed knowledge inside drivers/bios_emulator. The emulator should stay generic and call out to the video driver (or a small ops table) to translate an I/O port access into whatever the card needs - MMIO on BAR2 here, real I/O on x86. See comment on patch 7. > This series contains a bunch of mischallaneous fixes to the BIOSEMU > codebase miscellaneous - also I noticed 'to to' and 'There some checkpatch warnings'. For upstream this will need a doc/ entry (which board, which defconfig, what to expect) and ideally test coverage. The QEMU RISC-V enablement in patch 8 is a nice way to make that reproducible - please consider keeping it so it can run in CI. Regards, Simon
