Hi Quentin, On Mon, Jul 20, 2026 at 2:57 PM Quentin Schulz <[email protected]> wrote:
> Where is this layout defined? > > Considering the env size is 0x1000, the same as the erase block size of > the SPI NOR flash you add support for in patch 3... I would have > imagined to simply use 0x3f7000 (or 0x3f9000) (or have them aligned with > the ones you are trying to use for the ROC-PC-RK3588S, which is 0x40000). There is no separately defined SPI NOR layout; my commit message was misleading in that regard. CONFIG_ENV_SECT_SIZE is 0x1000, but CONFIG_ENV_SIZE is 0x8000. Therefore, each environment copy occupies 32 KiB rather than 4 KiB. The existing environment starts at 0x3f8000 and occupies 0x3f8000–0x3fffff. To preserve the existing environment location as the redundant copy, I placed the primary copy immediately before it at 0x3f0000. This gives two adjacent, non-overlapping 32 KiB regions, both aligned to the 4 KiB erase-sector size. I will reword the commit message to describe this explicitly and remove the reference to an “existing SPI NOR layout.”
