On 7/22/26 1:39 PM, Boogie wrote:
[You don't often get email from [email protected]. Learn why this is
important at https://aka.ms/LearnAboutSenderIdentification ]
Hi Quentin
On 7/22/26 11:28, Quentin Schulz wrote:
Hi Hüseyin, Johan,
On 7/22/26 12:56 AM, Boogie wrote:
[...]
Rockchip NFC technically as minimum needs to know rockchip,boot-blks, &
rockchip,boot-ecc-strength props only. Currently the checking condition
is rockchip,boot-blks & applied affect is rockchip,boot-ecc-strength.
The bug is this is only applicable to first chip not all chips.
"is only applied" I think you meant here instead? Or are you implying
that you want chip 0 to have rockchip,boot-blks and rockchip,boot-ecc-
strength applied to it, but NOT chip 2 even though they are listed in
the same node?
Yes boot-blks and rockchip,boot-ecc-strength must be applied to only to
the chip CS=0. This is how the bootrom works, bootrom does not look for
an idb image [tpl/spl] in a chip which is not CS == 0.
The BootROM can only read from chip 0, and with a specific (lower I
guess) ECC strength. That I understood and is a limitation we cannot
work-around.
I was trying to figure out if you wanted to have chip 2 have a different
ECC strength than chip 0 while being in the same node (and thus,
necessarily with the same properties). Considering the properties are in
a node with multiple chips (via the reg property), I would think the
properties should apply to *all* chips in that node. Considering the
kernel doesn't support this (from a cursory glance, maybe I misread the
code), if you want something different, you need to discuss this with
the Linux kernel MTD and Device Tree maintainers to have this validated
first. I think they won't agree simply because we cannot know for sure
that all (past and future) SoCs will forever only read from chip 0 and
would result in different behaviors with the exact same node for
different SoCs, but maybe I'm wrong :)
[...]
Additional note: Linux mainline also is lacking the "nfc->selected_bank
== 0" check, so i think similar patch should got to linux as well.
Not sure what you mean here as Johan removed both checks in the patch.
You are right, sorry for misleading, we had discussed to put a lock to
with "&& nfc->selected_bank == 0" for both read and write to uniform.
But now i noticed that this patch only syncs with mainline and
downgrades the ECC to bootrom strength for all chips first boot blocks.
This also works, but of course the side affect is reduced ecc strength
(if your current one is higher, and most likely is).
Indeed. Thanks for the confirmation!
Cheers,
Quentin
