Hi Fabio,
On 7/22/26 8:40 PM, Fabio Estevam via U-Boot wrote:
From: Fabio Estevam <[email protected]>
The ROC-PC-RK3588S board is an SBC made by Firefly, based on the RK3588S
SoC.
Add support for it.
Signed-off-by: Fabio Estevam <[email protected]>
---
Changes since v2:
- Drop the USB device-mode DT changes until they are available through
devicetree-rebasing.
- Drop the corresponding USBDP, DWC3, gadget and UMS options.
Just to be sure this isn't an oversight, DWC3 is used for
usb_host0_xhci, which is enabled on ROC-PC-RK3588S. I see there are a
USB-A port marked as USB3 on the product datasheet, and also USB OTG
that is capable of doing USB3. I couldn't quickly find schematics to
verify what's what, so does the full USB-A marked as being USB3 capable
still working?
Reviewed-by: Quentin Schulz <[email protected]>
[...]
diff --git a/board/firefly/roc-pc-rk3588s/MAINTAINERS
b/board/firefly/roc-pc-rk3588s/MAINTAINERS
new file mode 100644
index 000000000000..a0316cab1b92
--- /dev/null
+++ b/board/firefly/roc-pc-rk3588s/MAINTAINERS
@@ -0,0 +1,6 @@
+ROC-PC-RK3588S
It's actually ROC-RK3588S-PC (c.f.
https://wiki.t-firefly.com/en/ROC-RK3588S-PC/), I can fix this up when
applying if you want, if there's no need for a v4 based on feedback above.
The files are "fine" like that as all other Firefly ROC-* products also
make the same "mistake" so better stay consistent :D
[...]
diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
index b565aea311e9..d56d245dc114 100644
--- a/doc/board/rockchip/rockchip.rst
+++ b/doc/board/rockchip/rockchip.rst
@@ -155,6 +155,7 @@ List of mainline supported Rockchip boards:
- Rockchip EVB (evb-rk3588)
- Edgeble Neural Compute Module 6A SoM - Neu6a (neu6a-io-rk3588)
- Edgeble Neural Compute Module 6B SoM - Neu6b (neu6b-io-rk3588)
+ - Firefly ROC-PC-RK3588S (roc-pc-rk3588s)
Ditto for typo (the defconfig part is fine).
Thanks!
Quentin
