Hi Mark,
On Sat, Jul 25, 2026 at 7:28 PM Mark Kettenis <[email protected]> wrote:
>
> > Date: Sat, 25 Jul 2026 18:41:58 +0800
> > From: Leo Liang via U-Boot <[email protected]>
>
> Sorry I didn't spot it before but...
>
> > On Mon, Jun 22, 2026 at 12:43:07PM -0700, Charles Perry wrote:
> > > log_debug() cannot be used before log_init() has been called. Remove the
> > > log_debug() statement in enable_caches() since it is called after
> > > log_init() in initcall_run_r().
>
> This part of the commit message contradicts itself. Should "after" in
> the second sentence be "before"?
>
Thanks for the catch!
It should be
'log_debug() statement in enable_caches() since it is called
**before** log_init() in initcall_run_r().'
I will correct it when merging the patch.
Best regards,
Leo
> > >
> > > This fixes a bug where a RISC-V system which does not have the "zicbom"
> > > extension (such as PIC64-HPSC/HX) would get lost in an infinite loop in
> > > log_dispatch().
> > >
> > > Fixes: 9e859849e2ca ("riscv: cache: Add CBO instructions")
> > > Signed-off-by: Charles Perry <[email protected]>
> > > ---
> > > arch/riscv/lib/cache.c | 2 --
> > > 1 file changed, 2 deletions(-)
> >
> > Applied to u-boot-riscv/main, thanks.
> >
> > Reviewed-by: Leo Yu-Chi Liang <[email protected]>
> >
> > Best regards,
> > Leo
> >
