Hi Rasmus, On 2026-07-23T09:38:22, Rasmus Villemoes <[email protected]> wrote:
> - Implement the "allow string list a value" for distinguished-name > properties alluded to in v1, as it might as well be done now and > doesn't take a lot of code. > > - Verify that property values in the distinguished-name node are > strings or string lists. The series adds a fair amount of new logic but only touches x509_cert.dts, and only to move the CN into the subnode. Several new paths have no coverage: the list branch in dict_to_config_section() that emits the '1.OU'/'2.OU' form, the Raise() for an invalid property value in the distinguished-name node, and the derived-class default_dist_name defaults in ti_secure and ti_secure_rom. Binman aims for 100% coverage, so 'binman test -T' will flag these. Please can you add test cases for the multi-value list encoding and the invalid-value error path? A small dts snippet with an 'OU' string list, and one with a non-string value to hit the Raise(), should do it. That also documents the new subnode format. tools/binman/btool/openssl.py 52 3 94% tools/binman/etype/x509_cert.py 81 1 99% Regards, Simon
