Hi Weijie, > All currently supported ESMT/EON flashes supports 4KB sector and dual read. > EN25Q80B also supports 1-1-4 quad read.
This is inconsistent with... > > Link: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25Q80B.pdf > Link: > https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25QH128A%20(2TC).pdf > Link: https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25S64A(2SC).pdf > Signed-off-by: Weijie Gao <[email protected]> > --- > v8: not changed > v7: removed SPI_NOR_QUAD_READ from en25q80b > v6: removed SPI_NOR_QUAD_READ from incompatible flashes > v5: not changed > v3-v4: updated commit message > v2: not changed > --- > drivers/mtd/spi/spi-nor-ids.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c > index c0fa98424aa..cf51f0ffa0b 100644 > --- a/drivers/mtd/spi/spi-nor-ids.c > +++ b/drivers/mtd/spi/spi-nor-ids.c > @@ -90,12 +90,12 @@ const struct flash_info spi_nor_ids[] = { > #endif > #ifdef CONFIG_SPI_FLASH_EON /* EON */ > /* EON -- en25xxx */ > - { INFO("en25q80b", 0x1c3014, 0, 64 * 1024, 16, SECT_4K) }, > - { INFO("en25q32b", 0x1c3016, 0, 64 * 1024, 64, 0) }, > - { INFO("en25q64", 0x1c3017, 0, 64 * 1024, 128, SECT_4K) }, > - { INFO("en25q128b", 0x1c3018, 0, 64 * 1024, 256, 0) }, > - { INFO("en25qh128", 0x1c7018, 0, 64 * 1024, 256, 0) }, > - { INFO("en25s64", 0x1c3817, 0, 64 * 1024, 128, SECT_4K) }, > + { INFO("en25q80b", 0x1c3014, 0, 64 * 1024, 16, SECT_4K | > SPI_NOR_DUAL_READ) }, this. Please update commit description. With that fix, Reviewed-by: Takahiro Kuwano <[email protected]> > + { INFO("en25q32b", 0x1c3016, 0, 64 * 1024, 64, SECT_4K | > SPI_NOR_DUAL_READ) }, > + { INFO("en25q64", 0x1c3017, 0, 64 * 1024, 128, SECT_4K | > SPI_NOR_DUAL_READ) }, > + { INFO("en25q128b", 0x1c3018, 0, 64 * 1024, 256, SECT_4K | > SPI_NOR_DUAL_READ) }, > + { INFO("en25qh128", 0x1c7018, 0, 64 * 1024, 256, SECT_4K | > SPI_NOR_DUAL_READ) }, > + { INFO("en25s64", 0x1c3817, 0, 64 * 1024, 128, SECT_4K | > SPI_NOR_DUAL_READ) }, > #endif > #ifdef CONFIG_SPI_FRAM_FUJITSU > /* Fujitsu MB85RS256TY */ > -- > 2.45.2
