Hi Julien,

Thank you for the patch.

On Tue, Jul 28, 2026 at 17:01, Julien Stephan <[email protected]> wrote:

> Add a new driver for the HDMI PHY. The driver supports MT8188 and MT8195
> based SoCs. The driver is based on the corresponding kernel driver
> (Commit 7a4ce5a9b674 - phy: mediatek: phy-mtk-hdmi-mt8195: convert from
> round_rate() to determine_rate()).

In the future, consider using standard commit formats, see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

In this example, that would give us:
commit 7a4ce5a9b674 ("phy: mediatek: phy-mtk-hdmi-mt8195: convert from 
round_rate() to determine_rate()")

>
> Signed-off-by: Pavlo Yadvychuk <[email protected]>
> Signed-off-by: Julien Stephan <[email protected]>

I've reviewed this comparing to the upstream linux driver. I don't see
anything strange. This looks like a clean port to me.

Reviewed-by: Mattijs Korpershoek <[email protected]>

Reply via email to