Hi Johan, On 7/30/2026 3:35 PM, Johan Jonker wrote: > README.rockchip must be removed. > Move the rkspi comment section to rkspi.c > > Signed-off-by: Johan Jonker <[email protected]> > Reviewed-by: Simon Glass <[email protected]> > --- > tools/rkspi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > -- > 2.39.5 > > diff --git a/tools/rkspi.c b/tools/rkspi.c > index f2530f7bde34..4f98a60a0692 100644 > --- a/tools/rkspi.c > +++ b/tools/rkspi.c > @@ -3,7 +3,11 @@ > * (C) Copyright 2015 Google, Inc > * Written by Simon Glass <[email protected]> > * > - * See README.rockchip for details of the rkspi format > + * rkspi.c produces an image consisting of a header and u-boot-spl-dtb.bin.
As for rksd, 'u-boot-spl-dtb.bin' is not really used, binman mkimage node select what images is used. Typically TPL + SPL, or SPL + proper. > + * The resulting image is then spread out so that only the first 2KB of each > 4KB > + * sector is used. The header is the same as with rksd and the maximum size > is > + * also 32KB (before spreading). The image should be written to the start of The size limit is also wrong here and is SoC specific and the offset where the resulting mkimage should be written to is also SoC specific. The offsets is only correct for u-boot-rockchip[-spi].bin files, not for the images that mkimage produces. The only information possible worth mentioning here is that the first 2KB of each 4KB page is used, but this is already documented further down in this file. Suggest you just drop the reference to README.rockchip here. Regards, Jonas > + * SPI flash. > */ > > #include "imagetool.h"
