According to the TPS65219 datasheet, selectors 0x38 through 0x3f
map to 3.4 V for LDO1 and LDO2.

For LDO3 and LDO4, selectors 0x00 through 0x0c map to 1.2 V,
while selectors 0x36 through 0x3f map to 3.3 V.

The driver currently uses 0x56, 0x12, and 0x54 as selector boundary
values. These values do not match the selector boundaries defined by
the datasheet.

Use the correct selector boundary values of 0x38, 0x0c, and 0x36.

Fixes: b5cfa0c7ca4f ("power: add driver for the TPS65219 PMIC")
Signed-off-by: Kumara Bhimeswararao Matsa <[email protected]>
---
Changes in v2:
- Fix the LDO1/LDO2 selector boundary in addition to LDO3/LDO4.
- Update the subject and commit message to cover all LDO selector boundaries.

 include/power/tps65219.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/power/tps65219.h b/include/power/tps65219.h
index e8780af2d81..c3114f26e1d 100644
--- a/include/power/tps65219.h
+++ b/include/power/tps65219.h
@@ -47,10 +47,10 @@
 #define TPS65219_LDO12_VOLT_MIN                 600000
 #define TPS65219_LDO12_VOLT_MAX                3400000
 #define TPS65219_LDO12_VOLT_REG_MIN    0
-#define TPS65219_LDO12_VOLT_REG_MAX    0x56
+#define TPS65219_LDO12_VOLT_REG_MAX    0x38
 #define TPS65219_LDO34_VOLT_MIN                1200000
 #define TPS65219_LDO34_VOLT_MAX                3300000
-#define TPS65219_LDO34_VOLT_REG_MIN    0x12
-#define TPS65219_LDO34_VOLT_REG_MAX    0x54
+#define TPS65219_LDO34_VOLT_REG_MIN    0x0c
+#define TPS65219_LDO34_VOLT_REG_MAX    0x36
 
 #endif /* TPS65219_H */

base-commit: 100e12ea78c73071b9710f08b32fd4590019266f
-- 
2.43.0

Reply via email to