The current driver defines dsi_generic_write_seq as a wrapper around mipi_dsi_dcs_write_buffer.
Now that mipi_dsi.h defines such macro, we can use the common one. Note that we use mipi_dsi_dcs_write_seq instead of mipi_dsi_generic_write_seq to keep the same behaviour. No functional changes intended. Signed-off-by: Julien Stephan <[email protected]> --- drivers/video/lg-lh400wv3-sd04.c | 58 +++++++++++++++++----------------------- 1 file changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/video/lg-lh400wv3-sd04.c b/drivers/video/lg-lh400wv3-sd04.c index 0385b39867f..8e6b5d2d723 100644 --- a/drivers/video/lg-lh400wv3-sd04.c +++ b/drivers/video/lg-lh400wv3-sd04.c @@ -35,22 +35,14 @@ static struct display_timing default_timing = { .vsync_len.typ = 4, }; -#define dsi_generic_write_seq(dsi, cmd, seq...) do { \ - static const u8 b[] = { cmd, seq }; \ - int ret; \ - ret = mipi_dsi_dcs_write_buffer(dsi, b, ARRAY_SIZE(b)); \ - if (ret < 0) \ - return ret; \ - } while (0) - static int lg_lh400wv3_enable_backlight(struct udevice *dev) { struct mipi_dsi_panel_plat *plat = dev_get_plat(dev); struct mipi_dsi_device *dsi = plat->device; int ret; - dsi_generic_write_seq(dsi, MIPI_DCS_EXIT_INVERT_MODE); - dsi_generic_write_seq(dsi, MIPI_DCS_SET_TEAR_ON); + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_EXIT_INVERT_MODE); + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_TEAR_ON); ret = mipi_dsi_dcs_set_pixel_format(dsi, MIPI_DCS_PIXEL_FMT_24BIT | MIPI_DCS_PIXEL_FMT_24BIT << 4); @@ -59,28 +51,28 @@ static int lg_lh400wv3_enable_backlight(struct udevice *dev) return ret; } - dsi_generic_write_seq(dsi, 0xb2, 0x00, 0xc8); - dsi_generic_write_seq(dsi, 0xb3, 0x00); - dsi_generic_write_seq(dsi, 0xb4, 0x04); - dsi_generic_write_seq(dsi, 0xb5, 0x42, 0x10, 0x10, 0x00, 0x20); - dsi_generic_write_seq(dsi, 0xb6, 0x0b, 0x0f, 0x3c, 0x13, 0x13, 0xe8); - dsi_generic_write_seq(dsi, 0xb7, 0x4c, 0x06, 0x0c, 0x00, 0x00); - - dsi_generic_write_seq(dsi, 0xc0, 0x01, 0x11); - dsi_generic_write_seq(dsi, 0xc3, 0x07, 0x03, 0x04, 0x04, 0x04); - dsi_generic_write_seq(dsi, 0xc4, 0x12, 0x24, 0x18, 0x18, 0x02, 0x49); - dsi_generic_write_seq(dsi, 0xc5, 0x65); - dsi_generic_write_seq(dsi, 0xc6, 0x41, 0x63); - - dsi_generic_write_seq(dsi, 0xd0, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04); - dsi_generic_write_seq(dsi, 0xd1, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04); - dsi_generic_write_seq(dsi, 0xd2, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04); - dsi_generic_write_seq(dsi, 0xd3, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04); - dsi_generic_write_seq(dsi, 0xd4, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04); - dsi_generic_write_seq(dsi, 0xd5, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04); - - dsi_generic_write_seq(dsi, MIPI_DCS_SET_COLUMN_ADDRESS, 0x00, 0x00, 0x01, 0xdf); - dsi_generic_write_seq(dsi, MIPI_DCS_SET_PAGE_ADDRESS, 0x00, 0x00, 0x03, 0x1f); + mipi_dsi_dcs_write_seq(dsi, 0xb2, 0x00, 0xc8); + mipi_dsi_dcs_write_seq(dsi, 0xb3, 0x00); + mipi_dsi_dcs_write_seq(dsi, 0xb4, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xb5, 0x42, 0x10, 0x10, 0x00, 0x20); + mipi_dsi_dcs_write_seq(dsi, 0xb6, 0x0b, 0x0f, 0x3c, 0x13, 0x13, 0xe8); + mipi_dsi_dcs_write_seq(dsi, 0xb7, 0x4c, 0x06, 0x0c, 0x00, 0x00); + + mipi_dsi_dcs_write_seq(dsi, 0xc0, 0x01, 0x11); + mipi_dsi_dcs_write_seq(dsi, 0xc3, 0x07, 0x03, 0x04, 0x04, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xc4, 0x12, 0x24, 0x18, 0x18, 0x02, 0x49); + mipi_dsi_dcs_write_seq(dsi, 0xc5, 0x65); + mipi_dsi_dcs_write_seq(dsi, 0xc6, 0x41, 0x63); + + mipi_dsi_dcs_write_seq(dsi, 0xd0, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xd1, 0x00, 0x46, 0x74, 0x32, 0x1d, 0x03, 0x51, 0x15, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xd2, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xd3, 0x00, 0x46, 0x74, 0x32, 0x1f, 0x03, 0x51, 0x15, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xd4, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04); + mipi_dsi_dcs_write_seq(dsi, 0xd5, 0x01, 0x46, 0x74, 0x25, 0x00, 0x03, 0x51, 0x15, 0x04); + + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_COLUMN_ADDRESS, 0x00, 0x00, 0x01, 0xdf); + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_SET_PAGE_ADDRESS, 0x00, 0x00, 0x03, 0x1f); ret = mipi_dsi_dcs_exit_sleep_mode(dsi); if (ret < 0) { @@ -90,7 +82,7 @@ static int lg_lh400wv3_enable_backlight(struct udevice *dev) mdelay(120); - dsi_generic_write_seq(dsi, MIPI_DCS_WRITE_MEMORY_START); + mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_MEMORY_START); ret = mipi_dsi_dcs_set_display_on(dsi); if (ret < 0) { -- 2.54.0
