Re: [PATCH v4 3/4] rockchip: rk3399: Add ROC-PC-PLUS board detection

[Fabio Estevam]

Hi Quentin,

On Wed, Aug 12, 2026 at 5:05 AM Quentin Schulz <u-b...@0leil.net> wrote:

> It should be !CONFIG_IS_ENABLED(DM_I2C) as CONFIG_IS_ENABLED is going to
> add the appropriate prefix based on the current stage being built (so
> definitely no SPL/TPL/VPL to be added manually) and CONFIG_SPL_I2C is
> not enough to build the dm_i2c_probe implementation, we need
> CONFIG_SPL_DM_I2C (well, and CONFIG_SPL_I2C because otherwise the
> drivers/i2c directory isn't traversed and because SPL_DM_I2C is missing
> a dependency on it).

I tested !CONFIG_IS_ENABLED(DM_I2C) alone, but the mezzanine SPL still
fails to link because SPL_DM_I2C is enabled while SPL_I2C is not.

Checking both works:

if (!(CONFIG_IS_ENABLED(I2C) && CONFIG_IS_ENABLED(DM_I2C)))
    return false;

I tested the mezzanine build successfully with this change.

I'll use this in v5 unless you see an issue.

Thanks,

Fabio Estevam