On Mon, Aug 24, 2026 at 3:45 PM Stephan Gerhold
<[email protected]> wrote:

> > +#define AB8500_VAUX3_REGU    AB8500_REGU_CTRL2(0x0a)
> > +#define AB8500_VAUX3_SEL     AB8500_REGU_CTRL2(0x21)
> > +#define AB8500_VAUX3_EN_MASK GENMASK(1, 0)
> > +#define AB8500_VAUX3_REGU_EN BIT(0)
> > +#define AB8500_VAUX3_SEL_MASK        GENMASK(2, 0)
> > +#define AB8505_VAUX3_SEL3    AB8500_REGU_CTRL2(0x01)
> > +#define AB8505_VAUX3_SEL3_MASK       BIT(4)
> > +#define AB8505_VAUX3_SEL3_UV 3050000
>
> I'm a bit confused by this list now, please either have all register
> addresses (AB8500_REGU_CTRL2(...)) at the top, followed by the bitmasks
> or make it interleaved (probably better for readability), i.e.

OK I fix!

> Am I blind or do we have no support for the AB8505 3.05V in the Linux
> regulator driver?

We do not.

I have a pending patch series fixing this and a few other issues in the
Linux driver, that I will send after the Linux merge window is over.

Yours,
Linus Walleij

Reply via email to